Added support for Next Available Subnet by Tags in Terraform#202
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional tag_filters support to the Next Available Subnet Terraform data source, enabling users to filter address blocks by tags.
- Introduces a
tag_filtersschema attribute and implements logic to list and filter subnets by matching tags. - Adds helper functions (
buildTagFilterString, error parsing,findSubnet) and updates error handling/ retry behavior. - Updates tests, examples, and documentation to cover and illustrate the new
tag_filtersfeature.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| internal/service/ipam/api_next_available_subnet_data_source.go | Schema updates, tag filter logic, retry & error parsing |
| internal/service/ipam/api_next_available_subnet_data_source_test.go | New acceptance tests for single/multiple tag filters |
| examples/data-sources/bloxone_ipam_next_available_subnets/data-source.tf | Example usage with tag_filters |
| docs/data-sources/ipam_next_available_subnets.md | Documentation updates for tag_filters and examples |
unasra
requested changes
May 29, 2025
unasra
left a comment
unasra
left a comment
Collaborator
There was a problem hiding this comment.
Relevant changes for this PR have been mentioned in the Addressblock PR
unasra
reviewed
Jun 18, 2025
…loxone into na_subnet_by_tags
unasra
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.